-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(after): surface after
errors in error overlay
#73449
base: lubieowoce/after-errors
Are you sure you want to change the base?
feat(after): surface after
errors in error overlay
#73449
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
54e465e
to
c798207
Compare
nwsapi
(revert later) (#73351)after
errors in error overlay
Failing test suitesCommit: c145214
Expand output● AfterContext › runs after() callbacks from a run() callback that resolves
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir action handling › should handle actions correctly after navigation / redirection events
● app-dir action handling › should handle actions correctly after following a relative link
Read more about building and testing Next.js in contributing.md.
Expand output● Edge runtime code with imports › test error if response is not Response type › Edge API dev test Response
● Edge runtime code with imports › test error if response is not Response type › Middleware dev test Response
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir edge runtime root layout › should not emit metadata files into bad paths
● app-dir edge runtime root layout › should mark static contain metadata routes as edge functions
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir edge SSR › should handle edge only routes
● app-dir edge SSR › should retrieve cookies in a server component in the edge runtime
● app-dir edge SSR › should treat process as object without polyfill in edge runtime
● app-dir edge SSR › should handle /index routes correctly
● app-dir edge SSR › should generate matchers correctly in middleware manifest
Read more about building and testing Next.js in contributing.md.
Expand output● Page using eval in development mode › does issue dynamic code evaluation warnings
● Middleware usage of dynamic code evaluation › development mode › shows a warning when running code with eval
● Middleware usage of dynamic code evaluation › development mode › does not show warning when no code uses eval
● Middleware usage of dynamic code evaluation › development mode › shows a warning when running WebAssembly.compile
● Middleware usage of dynamic code evaluation › development mode › shows a warning when running WebAssembly.instantiate with a buffer parameter
● Middleware usage of dynamic code evaluation › development mode › does not show a warning when running WebAssembly.instantiate with a module parameter
● Edge route usage of dynamic code evaluation › development mode › shows a warning when running code with eval
● Edge route usage of dynamic code evaluation › development mode › does not show warning when no code uses eval
● Edge route usage of dynamic code evaluation › development mode › shows a warning when running WebAssembly.compile
● Edge route usage of dynamic code evaluation › development mode › shows a warning when running WebAssembly.instantiate with a buffer parameter
● Edge route usage of dynamic code evaluation › development mode › does not show a warning when running WebAssembly.instantiate with a module parameter
Read more about building and testing Next.js in contributing.md.
Expand output● app-simple-routes › works with simple routes › renders a node route
● app-simple-routes › works with simple routes › renders a edge route
Read more about building and testing Next.js in contributing.md.
Expand output● app-routes-subrequests › shortcuts after 5 subrequests
Read more about building and testing Next.js in contributing.md.
Expand output● server-navigation-error › pages router › should error on navigation API redirect
● server-navigation-error › pages router › should error on navigation API notFound
● server-navigation-error › middleware › should error on navigation API redirect
● server-navigation-error › middleware › should error on navigation API not-found
Read more about building and testing Next.js in contributing.md.
Expand output● development mode › loads a middleware
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - css › css support › server layouts › should support global css inside server layouts
● app dir - css › css support › server layouts › should support css modules inside server layouts
● app dir - css › css support › server layouts › should support external css imports
● app dir - css › css support › server pages › should support global css inside server pages
● app dir - css › css support › server pages › should support css modules inside server pages
● app dir - css › css support › server pages › should not contain pages css in app dir page
● app dir - css › css support › client layouts › should support css modules inside client layouts
● app dir - css › css support › client layouts › should support global css inside client layouts
● app dir - css › css support › client pages › should support css modules inside client pages
● app dir - css › css support › client pages › should support global css inside client pages
● app dir - css › css support › client components › should support css modules inside client page
● app dir - css › css support › client components › should support css modules inside client components
● app dir - css › css support › special entries › should include css imported in loading.js
● app dir - css › css support › special entries › should include css imported in client template.js
● app dir - css › css support › special entries › should include css imported in server template.js
● app dir - css › css support › special entries › should include css imported in client not-found.js
● app dir - css › css support › special entries › should include css imported in server not-found.js
● app dir - css › css support › special entries › should include root layout css for root not-found.js
● app dir - css › css support › special entries › should include css imported in root not-found.js
● app dir - css › css support › special entries › should include css imported in error.js
● app dir - css › css support › page extensions › should include css imported in MDX pages
● app dir - css › css support › chunks › should bundle css resources into chunks
● app dir - css › css support › css ordering › should have inner layers take precedence over outer layers
● app dir - css › sass support › server layouts › should support global sass/scss inside server layouts
● app dir - css › sass support › server layouts › should support sass/scss modules inside server layouts
● app dir - css › sass support › server pages › should support global sass/scss inside server pages
● app dir - css › sass support › server pages › should support sass/scss modules inside server pages
● app dir - css › sass support › client layouts › should support global sass/scss inside client layouts
● app dir - css › sass support › client layouts › should support sass/scss modules inside client layouts
● app dir - css › sass support › client pages › should support global sass/scss inside client pages
● app dir - css › sass support › client pages › should support sass/scss modules inside client pages
● app dir - css › pages dir › should include css modules and global css after page transition
Read more about building and testing Next.js in contributing.md.
Expand output● development mode › logs the error correctly
● production mode › logs the error correctly
Read more about building and testing Next.js in contributing.md.
Expand output● develop - app-dir - edge errros hmr › should recover from build errors when server component error
● develop - app-dir - edge errros hmr › should recover from build errors when client component error
Read more about building and testing Next.js in contributing.md.
Expand output● Image Generation › production mode › should generate the image without errors
Read more about building and testing Next.js in contributing.md.
Expand output● router rerender › development mode › with middleware › should not trigger unnecessary rerenders when middleware is used
Read more about building and testing Next.js in contributing.md.
Expand output● Middleware overriding a Node.js API › development mode › does not show a warning and allows overriding
Read more about building and testing Next.js in contributing.md.
Expand output● Middleware in src/ folder › development mode › loads an runs src middleware
● Middleware in src/ folder › production mode › should warn about middleware on export
● Middleware in src/ and / folders › development mode › loads and runs only root middleware
● Middleware in src/ and / folders › production mode › should warn about middleware on export
Read more about building and testing Next.js in contributing.md.
Expand output● Test suite failed to run
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - dynamic css › should only apply corresponding css for page loaded in edge runtime
● app dir - dynamic css › should only apply corresponding css for page loaded that /another
Read more about building and testing Next.js in contributing.md.
Expand output● streaming dev dev › should support streaming for fizz response
● streaming dev dev › should not stream to crawlers or google pagerender bot
● streaming dev dev › should render 500 error correctly
● streaming dev dev › should render fallback if error raised from suspense during streaming
● production mode › streaming prod prod › should support streaming for fizz response
● production mode › streaming prod prod › should not stream to crawlers or google pagerender bot
● production mode › streaming prod prod › should render 500 error correctly
● production mode › streaming prod prod › should render fallback if error raised from suspense during streaming
Read more about building and testing Next.js in contributing.md.
Expand output● dynamic-io › Async Params › should prerender pages that await params in a server component when prebuilt
● dynamic-io › Async Params › should prerender pages that
● dynamic-io › Async Params › should render pages that await params in a server component when not prebuilt
● dynamic-io › Async Params › should render pages that
● dynamic-io › Async Params › should fully prerender pages that check individual param keys after awaiting params in a server component
● dynamic-io › Async Params › should fully prerender pages that check individual param keys after
● dynamic-io › Async Params › should prerender pages that spread awaited params in a server component when prebuilt
● dynamic-io › Async Params › should prerender pages that spread
● dynamic-io › Async Params › should render pages that spread awaited params in a server component when not prebuilt
● dynamic-io › Async Params › should render pages that spread
● dynamic-io › Synchronous Params access › should prerender pages that access params synchronously in a server component when prebuilt
● dynamic-io › Synchronous Params access › should prerender pages that access params synchronously in a client component when prebuilt
● dynamic-io › Synchronous Params access › should render pages that access params synchronously in a server component when not prebuilt
● dynamic-io › Synchronous Params access › should render pages that access params synchronously in a client component when not prebuilt
● dynamic-io › Synchronous Params access › should fully prerender pages that check individual param keys directly on the params prop in a server component
● dynamic-io › Synchronous Params access › should fully prerender pages that check individual param keys directly on the params prop in a client component
● dynamic-io › Synchronous Params access › should prerender pages that spread params without awaiting first in a server component when prebuilt
● dynamic-io › Synchronous Params access › should prerender pages that spread params without
● dynamic-io › Synchronous Params access › should prerender pages that spread params without awaiting first in a server component when not prebuilt
● dynamic-io › Synchronous Params access › should prerender pages that spread params without
● dynamic-io › Param Shadowing › should correctly allow param names like then, value, and status when awaiting params in a server component
● dynamic-io › Param Shadowing › should correctly allow param names like then, value, and status when
● dynamic-io › Param Shadowing › should not allow param names like then and status when accessing params directly in a server component
● dynamic-io › Param Shadowing › should not allow param names like then and status when accessing params directly in a client component
Read more about building and testing Next.js in contributing.md.
Expand output● Middleware Production Prefetch › production mode › prefetch correctly for unexistent routes
● Middleware Production Prefetch › production mode › does not prefetch provided path if it will be rewritten
Read more about building and testing Next.js in contributing.md.
Expand output● app-dir-hmr › filesystem changes › should update server components after navigating to a page with a different runtime
● app-dir-hmr › filesystem changes › should update server components pages when env files is changed (node)
● app-dir-hmr › filesystem changes › should update server components pages when env files is changed (node-module-var)
● app-dir-hmr › filesystem changes › should update server components pages when env files is changed (edge)
● app-dir-hmr › filesystem changes › should update server components pages when env files is changed (edge-module-var)
● app-dir-hmr › filesystem changes › can navigate cleanly to a page that requires a change in the Webpack runtime
Read more about building and testing Next.js in contributing.md.
Expand output● dynamic-io › should produce dynamic pages when using async or sync cookies
● dynamic-io › should be able to access cookie properties asynchronously
● dynamic-io › should be able to access cookie properties synchronously
Read more about building and testing Next.js in contributing.md.
Expand output● app-routes-trailing-slash › should handle trailing slash for edge runtime
● app-routes-trailing-slash › should handle trailing slash for node runtime
Read more about building and testing Next.js in contributing.md.
Expand output● production mode › Concurrent mode in the experimental-edge runtime prod › flushes styled-jsx styles as the page renders
● production mode › Concurrent mode in the experimental-edge runtime prod › › should not have the initial route announced
● production mode › Concurrent mode in the experimental-edge runtime prod › should not have invalid config warning
Read more about building and testing Next.js in contributing.md.
Expand output● react-dom/server in React Server environment › implicit react-dom/server.edge usage in library code
Read more about building and testing Next.js in contributing.md. |
9a8ade7
to
b637690
Compare
c798207
to
54181f4
Compare
b637690
to
e9da061
Compare
54181f4
to
855f8c0
Compare
e9da061
to
761fa76
Compare
855f8c0
to
e5df5f1
Compare
@@ -501,13 +516,24 @@ function processMessage( | |||
// TODO-APP: potentially only refresh if the currently viewed page was added/removed. | |||
return router.hmrRefresh() | |||
} | |||
case HMR_ACTIONS_SENT_TO_BROWSER.AFTER_ERROR: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was assuming we just console.error
these. That way we cover Terminal, Node.js debuggers and the error overlay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed offline, the problem is that after
errors occur after everything else, so we can't rely on e.g. react's error replaying to get them here, we need to push them (technically the client could also try to pull, maybe that's a better strategy?)
1e3c813
to
ae85cce
Compare
981f9b9
to
2601c8c
Compare
ae85cce
to
ef47933
Compare
c03f2a4
to
c9a64d5
Compare
ef47933
to
bd6cb75
Compare
c9a64d5
to
8e57164
Compare
bd6cb75
to
275eccc
Compare
8e57164
to
2313f46
Compare
275eccc
to
5401626
Compare
2313f46
to
4e9eb8c
Compare
4e9eb8c
to
1b57ac1
Compare
5401626
to
06fde3b
Compare
No description provided.